(CHORE)[EX-3143] Upgrade protoc-cpp with protoc 1.15#186
Closed
Michael Gunawan (scmichaelg) wants to merge 6 commits intomainfrom
Closed
(CHORE)[EX-3143] Upgrade protoc-cpp with protoc 1.15#186Michael Gunawan (scmichaelg) wants to merge 6 commits intomainfrom
Michael Gunawan (scmichaelg) wants to merge 6 commits intomainfrom
Conversation
- Alpine 3.15 → 3.21 - buf 1.8.0 → 1.66.0 - protoc/grpc from Alpine 3.21 community repo (protobuf v24.4, grpc 1.62.1) Split from upgrade/alpine-3.21-protobuf-v24 to unblock protoc-cpp build.
protoc-gen-workato@latest now requires go >= 1.24.0. Bump protoc-go version to 3.26.0.
- protoc base image: Alpine 3.15 -> 3.21, buf 1.8.0 -> 1.66.0 - protoc 3.18.1 -> 24.4, grpc 1.62.1 (from community repo) - protoc-cpp image: base protoc 1.14.2 -> 1.15.0 - Add abseil-cpp-dev and pkgconf build deps (required by protobuf v22+) - Regenerate wire_options.pb.cc/h during build to match container protobuf - Bump version to 1.13.0 - Fix legacy ENV format warning in Dockerfile Note: CRUX_CLIENT_RELEASE needs updating to a new s12-proto tag that includes the protobuf v24 string_view compatibility changes (see SafetyCulture/s12-proto PR upgrade/protobuf-v33-compatibility). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Michael Gunawan (scmichaelg)
changed the base branch from
main
to
EX-3143/upgrade-protoc-base-1.15.0
Michael Gunawan (scmichaelg)
changed the title
Michael Gunawan (scmichaelg)
changed the title
2 tasks
Michael Gunawan (scmichaelg)
changed the base branch from
EX-3143/upgrade-protoc-base-1.15.0
to
main
In Alpine 3.21, grpc_cpp_plugin is in a separate grpc-plugins package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the base
protocimage to Alpine 3.21 with buf 1.66.0, updatesprotoc-cppto use the new base image with s12-proto 1.38.0, and bumpsprotoc-goto Go 1.24.0.EX-3143
Problem description
The protoc Docker images were running on outdated Alpine and dependency versions. The
protoc-cppbuild was also failing because thewire_options.pb.cc/hfiles generated from an older protobuf version were incompatible with the newer protobuf libraries in Alpine 3.21. This PR upgrades all base images and fixes the protoc-cpp build by regenerating the protobuf sources at build time and adding the requiredabseil-cpp-devandpkgconfdependencies.Changes
abseil-cpp-dev/pkgconfbuild deps, regeneratewire_options.pb.cc/hduring buildPros/cons of approach implemented
wire_options.pb.cc/hat build time ensures compatibility with whatever protobuf version is in the base image, avoiding future breakage on upgrades.protocinvocation to the build script, slightly increasing build time.Checklist
Is this PR a reasonable size?
List deployment sequence with all relevant PRs.
protocimage must be built and published first (protoc-cpp depends on it)protoc-cppandprotoc-gocan be built independentlyFor breaking changes: I have confirmed that other repos are not
affected, or I have planned a deployment sequence to address any impact.
Code Review Guidelines for Reviewers
blockers. Pair on a call for non-trivial feedback.
to make the PR perfect.
test coverage and complexity.
who is.